vmware-host-modules

0 Fork 0

Author	SHA1	Message	Date
Michal Kubecek	775e958d6b	vmmon: avoid using alloc_vm_area() for crosspage allocation Mainline commit 301fa9f2ddf7 ("mm: remove alloc_vm_area") in v5.10-rc1 removed alloc_vm_area() function used to allow allocating crosspage as executable after vmap() started silently setting NX flag in kernel 5.8. Similar to what upstream did in Xen code, use apply_to_page_range() to fix the crosspage flags, except we don't need to use get_vm_area() which is not exported. Thanks to virtualbox for the hint that current->mm can be used instead of init_mm (which is not exported either).	2020-12-09 11:18:16 +01:00
Michal Kubecek	57a50383ed	vmmon: avoid kernel writes to eventfd Starting with mainline commit 4d03e3cc5982 ("fs: don't allow kernel reads and writes without iter ops") in 5.10-rc1, kernel writes are only allowed for files providing ->write_iter() callback which eventfd does not. As an attempt to address this issue on kernel side by providing ->write_iter() callback to eventfd was met with a pushback and it is unlikely to be accepted any time soon, let's use a specific eventfd interface eventfd_signal() instead. However, as the comments in HostIF_SemaphoreSignal() indicate that the file descriptor may also be a pipe (without telling when), let's keep kernel_write() as a fallback in case the file descriptor is not eventfd.	2020-12-09 11:17:51 +01:00
Michal Kubecek	d33fe2a8da	vmmon: avoid set_fs() in HostIFFastClockThread() The set_fs() function was dropped on x86_64 architecture by commit 47058bb54b57 ("x86: remove address space overrides using set_fs()") in 5.10-rc1. The only purpose of set_fs(KERNEL_DS) in HostIFFastClockThread() seems to be to allow using ->read() file operation on /dev/rtc device. There is also ioctl() but neither of the two (RTC_IRQP_SET and RTC_PIE_ON) interprets its argument as a (user) pointer: RTC_IRQP_SET interprets it as unsigned long, RTC_PIE_ON ignores it. Replace the direct call to ->read() file op with kernel_read() wrapper like we did/do in other places and drop the temporary set_fs(KERNEL_DS) trick as it doesn't seem to be needed any more.	2020-12-09 11:16:22 +01:00
Michal Kubecek	d84ffdac5b	vmmon: avoid set_fs() in isVAReadable() The set_fs() function was dropped on x86_64 architecture by commit 47058bb54b57 ("x86: remove address space overrides using set_fs()") in 5.10-rc1. In isVAReadable() it is used to check if a kernel address can be read from without risking a pagefault if the answer is negative by using set_fs() to pretend it's a userspace address and checking with copy_from_user(). Starting with 5.8, copy_from_kernel_nofault() does can be used to copy from a kernel address with access check but without an actual pagefault.	2020-12-09 11:16:03 +01:00
Michal Kubecek	98a9df5040	vmmon: avoid set_fs() in HostIF_SemaphoreWait() and HostIF_SemaphoreSignal() The set_fs() function was dropped on x86_64 architecture by commit 47058bb54b57 ("x86: remove address space overrides using set_fs()") in 5.10-rc1. In HostIF_SemaphoreWait() it is used to allow calling read() file op on a kernel pointer, in HostIF_SemaphoreSignal() to allow calling write() file op on a kernel pointer. This is only the case for pre-5.8 kernels as we need to use kernel_read() and kernel_write() helpers on 5.8 and newer anyway. Use kernel_read() and kernel_write() always, like Workstation 16.0.0 does, so that we no longer need the set_fs(KERNEL_DS) trick. Make the code of both functions look exactly like in Workstation 16.0.0 to make future backports easier.	2020-12-09 11:15:34 +01:00
Michal Kubecek	d680c2be3f	vmnet: use new compat_csum_and_copy_to_user() calling convention Part of bigger csum_and_copy rework, commit c693cc4676a0 ("saner calling conventions for csum_and_copy_..._user()") in 5.10-rc1 drops last two arguments and changes the way errors are reported. Provide a compat wrapper with new calling convention and rewrite callers in vmnet to use it. Unfortunately there doesn't seem to be a way to recognize which calling convention kernel has so version check is used.	2020-12-09 11:15:06 +01:00

Compare commits

Diff Content Not Available