Commit Graph
1206 Commits
Author SHA1 Message Date
Mikio Hara aefade8e40 Spec: Rename flow expiration messages to flow removed
Now that delete operations can cause flow expirations, it makes sense
to rename them as flow removed messages.
2009-07-02 05:31:00 -07:00
Mikio Hara 01593f3c49 Namespace change: Rename flow expiration to flow removed 2009-07-01 19:58:06 -07:00
Mikio Hara 0f3d726853 Protocol stats: Revise to support new protocol messages and error codes 2009-07-01 13:27:21 -07:00
Mikio Hara 680f63b514 Rewrite IP ToS/DSCP: Add IP ToS/DSCP field rewrite feature 2009-07-01 11:28:51 -07:00
Brandon Heller b008eb8126 Fix typo
DSCP, not DCSP
2009-06-30 23:24:30 -07:00
Brandon Heller b1e7cc00bc Spec: Add IP ToS rewrite action
Enable additional basic QoS support, without requiring a full QoS
framework.  This commit defines a flow action to rewrite the DiffServ
CodePoint bits of the IP ToS field in the IP header.
2009-06-30 22:07:13 -07:00
Mikio Hara ed0d7bc8e8 Bug fix: Fix memory leak in stats reqeust handler 2009-06-30 20:46:41 -07:00
Brandon Heller 0f73f42fa6 Spec: Define failover behavior
Add notes about emergency vs normal flows, and define an expectation
for the switch to support multiple controller strings.
2009-06-30 18:02:54 -07:00
Brandon Heller 25d7c2ecd2 Spec: Fix typo in diagram
In the flow table matching picture, Ethernet type was compared to 0x8000
when 0x0800 was intended.
2009-06-29 22:42:40 -07:00
Brandon Heller 1e12e0771e Spec: Fix build error
Removed extra line
2009-06-29 22:31:08 -07:00
Brandon Heller 98ee054722 Spec: Minor change to CHECK_OVERLAP text 2009-06-29 11:37:28 -07:00
Brandon Heller 1a5762fbd2 Spec: Fix ambiguity regarding the duration field in Flow Expirations
Before this spec change, flow expiration messages included a duration
field for the time the flow was active.  To find out the amount of time
the flow received traffic would have been much harder - the controller
would need to store a record of all flow mods it has sent, to know the
idle_timeout of this flow.  Additionally, both phrases, 'time flow was
active' and 'time traffic was received' were used in the spec for the
duration field.

Now we return the idle timeout in the flow expiration message, and ensure
duration is the time the entry was present in the flow table.  The hard
timeout will be obvious if it is the reason for the deletion, since the
reason field will be OFPER_HARD_TIMEOUT, and the duration will be the hard
timeout value.  From the duration and the idle_timeout, we can also
compute the time the flow received traffic.
2009-06-29 11:37:28 -07:00
Brandon Heller 4f0da65910 Spec: Define behavior for conflicting flow mods
Define a CHECK_OVERLAP flag for flow mods which requires the switch to
check for conflicting entries with the same priority, i.e., those for
which at least one packet could match multiple entries.

This flags is intended to be used for debugging purposes; in the worst
case, it may require a linear check through the flow table.
2009-06-29 11:37:28 -07:00
Brandon Heller 91617a4690 Spec: Add VLAN priority bits
The OpenFlow 10-tuple is now officially an 11-tuple, with the addition of
the VLAN priority (PCP) field.
2009-06-29 11:37:28 -07:00
Brandon Heller 90bdc8626b Spec: Add barrier commands
Add barrier request message, which ensures that all previously received
commands are complete before executing ones past the barrier message.  A
barrier reply must be sent for each barrier request.

We expect this command to be useful for testing and wireless handover
purposes.
2009-06-29 11:37:28 -07:00
Brandon Heller f874420531 Spec: Start port enumeration at 1
A number of protocols such as SNMP and STP start counting ports at one. To
increase compatibility, this commit adds a requirement that OpenFlow
ingress port values start at one.
2009-06-29 11:37:28 -07:00
Brandon Heller e9353ae079 Spec: Add _EPERM error codes
An OpenFlow hypervisor might choose to reject an OpenFlow request, but
currently has no message type defined for this error. It is not a
vendor-specific error, thus we define an _EPERM error code for each error
type.

Also remove unused, commented-out text.
2009-06-29 11:37:14 -07:00
Brandon Heller c249b48f83 Spec: Replace hardcoded constant for MISS_SEND_LEN 2009-06-29 11:36:33 -07:00
Brandon Heller 31955e3ea4 Spec: Clarify buffer behavior 2009-06-29 11:36:33 -07:00
Brandon Heller cec522cd66 Spec: Clarify format for Strip VLAN action
Clarify that the OFPAT_STRIP_VLAN action takes no argument and strips the
VLAN tag if one is present. The header is the generic action header.
2009-06-29 11:36:33 -07:00
Brandon Heller 16e2b8ba6d Spec: Clarify transaction ID for error messages
Note that if an error is in response to a specific message from the
controller, the transaction ID should match that from the original
request.
2009-06-29 11:36:32 -07:00
Brandon Heller 4b969c68f3 Spec: Clarify matching for disabled STP ports
Packets received on ports that are disabled by spanning tree must follow
the normal flow table processing path.
2009-06-29 11:36:32 -07:00
Brandon Heller 3a7d98b612 Spec: Clarify matching behavior for flow mods and stats
The spec does not currently define how wildcard matching should behave for
flow modification (specifically DELETE and MODIFY commands) and stats.
This commit adds text to define behavior when some fields are wildcarded
and others are left exact.
2009-06-29 11:36:32 -07:00
Brandon Heller 1592042b19 Spec: Minor rearrangement of flow add text 2009-06-29 11:36:32 -07:00
Brandon Heller 0c370a5ef9 Spec: Remove distinction between Type 0 and Type 1
People tend to get confused about "Type 0" and "Type 1" vs "Version 1.0" and
"Version 2.0".  To simplify, we'll drop the reference to types.
2009-06-29 11:36:32 -07:00
Mikio Hara 0e59606d43 Remove experimental bridge compat header file 2009-06-29 11:36:09 -07:00
tyabe c5ca36a509 Emergency flow cache: Add regression test for emergency flow cache 2009-06-29 11:31:14 -07:00
Mikio Hara 292ffb1f39 Barrier command: Add new protocol messages: barrier request and reply
When a switch receives a barrier message it must first complete all
commands sent before the barrier message before executing any commands
after it. When all commands before the Barrier message have completed,
it must send a barrier reply message back to the controller.
2009-06-29 11:21:40 -07:00
Mikio Hara 6265df8d21 Remove experimental bridge compat framework 2009-06-29 10:04:11 -07:00
Mikio Hara 1ae2cd3781 Start port enumeration: Change OpenFlow start port enumeration at 1 2009-06-29 10:02:02 -07:00
Yiannis Yiakoumis a47208dc76 Flow mod behavior: Add a new flag to flow mods and flow conflict
detection handler for table maintanance

Add a CHECK_OVERLAP flag to flow mods which requires the switch to do
the (potentially more costly) check that there doesn't already exist a
conflicting flow with the same priority. If there is one, the mod
fails and an error code is returned.

Flow expiry: Record OFPFF_SEND_FLOW_EXP flag in user data path
2009-06-29 10:00:55 -07:00
tyabe c42075a48f Vlan pcp match: Regression tests modification and addition 2009-06-29 07:34:10 -07:00
tyabe 12760f91f2 Vlan pcp match: Add vlan_pcp for parse in dpctl.c 2009-06-29 07:29:21 -07:00
tyabe 7b35e83172 Vlan pcp match: Wireshark dissector support 2009-06-29 07:29:10 -07:00
tyabe 37d17d3012 NetFPGA project "register_system_2.0" adaptation 2009-06-29 07:28:44 -07:00
tyabe 73f268ab10 Vlan pcp match: Implemented on hwtable_nf2 (NetFPGA) 2009-06-29 07:28:26 -07:00
tyabe dde4979698 Vlan pcp match: Implemented on datapath and udatapath 2009-06-29 07:27:42 -07:00
tyabe@stanford.edu 5cebe4612a Flow expiry: Expire message when flow is deleted: NetFPGA support 2009-06-29 07:27:05 -07:00
Glen Gibb 875412fefd Flow expiry: Correct function proto for vendor_stats_init 2009-06-29 07:26:36 -07:00
tyabe e57b99969d Modify regression tests so as to: have an ability to reduce the number
of test port fix hard-coded max-ports number (thanks to Jean)
2009-06-29 07:25:08 -07:00
Glen Gibb fcfd27a96d Flow expiry: Test that flow expires are sent on flow delete 2009-06-29 07:08:30 -07:00
Glen Gibb 463abf9568 Flow expiry: Added OFPER_DELETE to known expire reasons 2009-06-29 07:08:17 -07:00
Glen Gibb fddc939b07 Flow expiry: Send flow expires on delete
Set the reason to OFPER_DELETE
2009-06-29 07:08:01 -07:00
Brandon Heller b5525791b5 Spec: Notify controller of flows that are forcefully deleted
Previously, a switch would only notify the controller when flows expired.
Now, when a switch is told to delete flows, it sends a flow expiration
message, enabling the controller to get packet and byte counts from
deleted flows. Without this, the controller must retrieve flow statistics
and then delete the flow, during which time the counts could change. This
could also aid in debugging if multiple applications or programs
controlling the same switch are deleting each others' flows.

This commit adds a OFPER_DELETE as a choice for the reason field of a flow
expiration.
2009-06-29 07:07:29 -07:00
Glen Gibb 33905ad47a Flow expiry: Added test to verify OFPFF_SEND_FLOW_EXP flag 2009-06-29 07:07:19 -07:00
Glen Gibb 039dc27cd3 Flow expiry: Remove enable_flow_expirations from everything 2009-06-29 07:06:56 -07:00
Glen Gibb ef82985afe Flow expiry: Set flags when creating flow mods
Each flow mod now has a send_flow_expiry flag indicating whether an
expiry message should be generated. The global config setting no longer
applies.
2009-06-29 07:06:28 -07:00
Glen Gibb 77a367ecd4 Flow expiry: Dissector now uses per-flow expiry 2009-06-29 07:06:07 -07:00
Glen Gibb b2b952792e Flow expiry: Replace refernces to OFPC_SEND_FLOW_EXP refs
Replaced references to OFPC_SEND_FLOW_EXP in dpinst with flow->send_flow_exp
2009-06-29 07:05:27 -07:00
Glen Gibb b7e8127132 Flow expiry: Remove send_ofp_exp references 2009-06-29 07:05:11 -07:00