This caused segfault instead of reporting the error.
The problem was that dp_lookup_port doesn't provide any sense
whether a port exists in the datapath. It refers to the
DP_MAX_PORTS entries to the switch, not to currently
configured ports in the switch. Instead of checking
p we check p->netdev and detect non-queue case.
Enable ofdatapath to run without slicing.
When the related dependencies are not met,
using the --no-slicing runtime option, ofdatapath
can run without tc backend/frontend support (and
therefore without slicing support).
tap devices do not have any queue configuration.
But we need to set queue_fd[0] which is the default
socket that best-effort traffic goes out.
When this was not set, fd defaulted to 0, which is
stdio, and resulted to print all packets.
Thanks Mikio for spotting the exact problem.
This commit updates the userspace datapath to handle the slicing
mechanism.
-> Keep list of queues per port.
-> Map flows to queues
-> Report queue configuration and statistics
-> Send appropriate error messages
Handle OF venor extensions (experimental). Currently only
for slicing configuration messages.
Slicing configuration messages are typically initiated by
dpctl. After capturing them here, we use the appropriate
functionality from datapath and netdev to change the
underlying queueing configuration.
netdev uses tc to implement the queueing mechanism.
Queue configuration takes place through dpctl.
Each queue is represented by a send-only socket, while
there is a default socket that receives traffic and
sends best-effort traffic. This is necessary to overcome
limitations from user-only implementation.
detection handler for table maintanance
Add a CHECK_OVERLAP flag to flow mods which requires the switch to do
the (potentially more costly) check that there doesn't already exist a
conflicting flow with the same priority. If there is one, the mod
fails and an error code is returned.
Flow expiry: Record OFPFF_SEND_FLOW_EXP flag in user data path
Yiannis Yiakoumis