tools: normalize nfdc exit codes

refs #3749

Change-Id: I0c81dff095c170390f62de82badc0cca7b53392d

docs/manpages/nfd-status.rst

@@ -47,6 +47,15 @@ If no options are provided, all information is retrieved.
 
 If -x is provided, other options(-v, -c, etc.) are ignored, and all information is printed in XML format.
 
+Exit Codes
+----------
+
+0: Success
+
+1: An unspecified error occurred
+
+2: Malformed command line
+
 Examples
 --------
 

docs/manpages/nfdc.rst

@@ -181,7 +181,14 @@ Options
         Note that when ``faceId`` is the last Face associated with ``prefix`` FIB entry,
         the whole FIB entry will be removed.
 
+Exit Codes
+----------
 
+0: Success
+
+1: An unspecified error occurred
+
+2: Malformed command line
 
 Examples
 --------

tools/nfdc/legacy-nfdc.cpp

@@ -357,7 +357,7 @@ legacyNfdcMain(ExecuteContext& ctx)
   catch (const po::error& e) {
     std::cerr << e.what() << std::endl;
     legacyNfdcUsage();
-    return 1;
+    return 2;
   }
 
   if (wantUnsetChildInherit) {
@@ -378,14 +378,14 @@ legacyNfdcMain(ExecuteContext& ctx)
       [] (const std::string& s) { return s.empty() || s[0] == '-'; })) {
     // unrecognized -option
     legacyNfdcUsage();
-    return 1;
+    return 2;
   }
   p.m_commandLineArguments = unparsed;
 
   bool isOk = p.dispatch(subcommand);
   if (!isOk) {
     legacyNfdcUsage();
-    return 1;
+    return 2;
   }
   ctx.face.processEvents();
   return 0;

tools/nfdc/main.cpp

@@ -56,7 +56,7 @@ main(int argc, char** argv)
   }
   catch (const std::invalid_argument& e) {
     std::cerr << e.what() << std::endl;
-    return 1;
+    return 2;
   }
 
   try {