avoid unnecessary empty strings ("") in favor of clear() and empty() (performance)
This commit is contained in:
vladon committed
1 parent
b6817e4c7e
commit
cd4af122c0
24 files changed
+94
-94
No files matched your search
@@ -113,7 +113,7 @@ BOOST_AUTO_TEST_CASE( negotiate_server_no_context_takeover_invalid ) {
|
||||
|
||||
BOOST_AUTO_TEST_CASE( negotiate_server_no_context_takeover ) {
|
||||
ext_vars v;
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
BOOST_CHECK( v.exts.is_enabled() );
|
||||
@@ -144,7 +144,7 @@ BOOST_AUTO_TEST_CASE( negotiate_client_no_context_takeover_invalid ) {
|
||||
|
||||
BOOST_AUTO_TEST_CASE( negotiate_client_no_context_takeover ) {
|
||||
ext_vars v;
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
BOOST_CHECK( v.exts.is_enabled() );
|
||||
@@ -282,7 +282,7 @@ BOOST_AUTO_TEST_CASE( negotiate_client_max_window_bits_invalid ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_client_max_window_bits_valid ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["client_max_window_bits"] = "";
|
||||
v.attr["client_max_window_bits"].clear();
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
BOOST_CHECK( v.exts.is_enabled() );
|
||||
BOOST_CHECK_EQUAL( v.esp.first, websocketpp::lib::error_code() );
|
||||
@@ -364,8 +364,8 @@ BOOST_AUTO_TEST_CASE( negotiate_client_max_window_bits_smallest ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated1 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
BOOST_CHECK( v.exts.is_enabled() );
|
||||
@@ -376,7 +376,7 @@ BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated1 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated2 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["server_max_window_bits"] = "10";
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
@@ -388,7 +388,7 @@ BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated2 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated3 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["client_max_window_bits"] = "10";
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
@@ -400,7 +400,7 @@ BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated3 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated4 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
v.attr["server_max_window_bits"] = "10";
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
@@ -412,7 +412,7 @@ BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated4 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated5 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
v.attr["client_max_window_bits"] = "10";
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
@@ -436,8 +436,8 @@ BOOST_AUTO_TEST_CASE( negotiate_two_client_initiated6 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated1 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
v.attr["server_max_window_bits"] = "10";
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
@@ -449,8 +449,8 @@ BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated1 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated2 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
v.attr["client_max_window_bits"] = "10";
|
||||
|
||||
v.esp = v.exts.negotiate(v.attr);
|
||||
@@ -462,7 +462,7 @@ BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated2 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated3 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["server_max_window_bits"] = "10";
|
||||
v.attr["client_max_window_bits"] = "10";
|
||||
|
||||
@@ -475,7 +475,7 @@ BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated3 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated4 ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
v.attr["server_max_window_bits"] = "10";
|
||||
v.attr["client_max_window_bits"] = "10";
|
||||
|
||||
@@ -488,8 +488,8 @@ BOOST_AUTO_TEST_CASE( negotiate_three_client_initiated4 ) {
|
||||
BOOST_AUTO_TEST_CASE( negotiate_four_client_initiated ) {
|
||||
ext_vars v;
|
||||
|
||||
v.attr["server_no_context_takeover"] = "";
|
||||
v.attr["client_no_context_takeover"] = "";
|
||||
v.attr["server_no_context_takeover"].clear();
|
||||
v.attr["client_no_context_takeover"].clear();
|
||||
v.attr["server_max_window_bits"] = "10";
|
||||
v.attr["client_max_window_bits"] = "10";
|
||||
|
||||
@@ -569,7 +569,7 @@ BOOST_AUTO_TEST_CASE( compress_data_no_context_takeover ) {
|
||||
|
||||
websocketpp::http::attribute_list alist;
|
||||
|
||||
alist["server_no_context_takeover"] = "";
|
||||
alist["server_no_context_takeover"].clear();
|
||||
v.exts.enable_server_no_context_takeover();
|
||||
|
||||
v.exts.negotiate(alist);
|
||||
@@ -586,7 +586,7 @@ BOOST_AUTO_TEST_CASE( compress_data_no_context_takeover ) {
|
||||
BOOST_CHECK_EQUAL( v.ec, websocketpp::lib::error_code() );
|
||||
BOOST_CHECK_EQUAL( compress_in, decompress_out );
|
||||
|
||||
decompress_out = "";
|
||||
decompress_out.clear();
|
||||
|
||||
v.ec = v.exts.compress(compress_in,compress_out2);
|
||||
BOOST_CHECK_EQUAL( v.ec, websocketpp::lib::error_code() );
|
||||
@@ -605,7 +605,7 @@ BOOST_AUTO_TEST_CASE( compress_data_no_context_takeover ) {
|
||||
BOOST_AUTO_TEST_CASE( compress_empty ) {
|
||||
ext_vars v;
|
||||
|
||||
std::string compress_in = "";
|
||||
std::string compress_in;
|
||||
std::string compress_out;
|
||||
std::string decompress_out;
|
||||
|
||||
@@ -616,8 +616,8 @@ BOOST_AUTO_TEST_CASE( compress_empty ) {
|
||||
|
||||
v.ec = v.exts.decompress(reinterpret_cast<const uint8_t *>(compress_out.data()),compress_out.size(),decompress_out);
|
||||
|
||||
compress_out = "";
|
||||
decompress_out = "";
|
||||
compress_out.clear();
|
||||
decompress_out.clear();
|
||||
|
||||
v.ec = v.exts.compress(compress_in,compress_out);
|
||||
BOOST_CHECK_EQUAL( v.ec, websocketpp::lib::error_code() );
|
||||
@@ -637,7 +637,7 @@ BOOST_AUTO_TEST_CASE( decompress_data ) {
|
||||
ext_vars v;
|
||||
|
||||
uint8_t in[11] = {0xf2, 0x48, 0xcd, 0xc9, 0xc9, 0x07, 0x00, 0x00, 0x00, 0xff, 0xff};
|
||||
std::string out = "";
|
||||
std::string out;
|
||||
std::string reference = "Hello";
|
||||
|
||||
v.exts.init(true);
|
||||
|
||||
@@ -115,7 +115,7 @@ BOOST_AUTO_TEST_CASE( extract_token ) {
|
||||
BOOST_CHECK( ret.second == d1.begin()+3 );
|
||||
|
||||
ret = websocketpp::http::parser::extract_token(d2.begin(),d2.end());
|
||||
BOOST_CHECK( ret.first == "" );
|
||||
BOOST_CHECK( ret.first.empty() );
|
||||
BOOST_CHECK( ret.second == d2.begin()+0 );
|
||||
|
||||
ret = websocketpp::http::parser::extract_token(d2.begin()+1,d2.end());
|
||||
@@ -127,7 +127,7 @@ BOOST_AUTO_TEST_CASE( extract_quoted_string ) {
|
||||
std::string d1 = "\"foo\"";
|
||||
std::string d2 = "\"foo\\\"bar\\\"baz\"";
|
||||
std::string d3 = "\"foo\" ";
|
||||
std::string d4 = "";
|
||||
std::string d4;
|
||||
std::string d5 = "foo";
|
||||
|
||||
std::pair<std::string,std::string::const_iterator> ret;
|
||||
@@ -147,11 +147,11 @@ BOOST_AUTO_TEST_CASE( extract_quoted_string ) {
|
||||
BOOST_CHECK( ret.second == d3.begin()+5 );
|
||||
|
||||
ret = extract_quoted_string(d4.begin(),d4.end());
|
||||
BOOST_CHECK( ret.first == "" );
|
||||
BOOST_CHECK( ret.first.empty() );
|
||||
BOOST_CHECK( ret.second == d4.begin() );
|
||||
|
||||
ret = extract_quoted_string(d5.begin(),d5.end());
|
||||
BOOST_CHECK( ret.first == "" );
|
||||
BOOST_CHECK( ret.first.empty() );
|
||||
BOOST_CHECK( ret.second == d5.begin() );
|
||||
}
|
||||
|
||||
@@ -185,7 +185,7 @@ BOOST_AUTO_TEST_CASE( extract_all_lws ) {
|
||||
}
|
||||
|
||||
BOOST_AUTO_TEST_CASE( extract_attributes_blank ) {
|
||||
std::string s = "";
|
||||
std::string s;
|
||||
|
||||
websocketpp::http::attribute_list a;
|
||||
std::string::const_iterator it;
|
||||
@@ -209,7 +209,7 @@ BOOST_AUTO_TEST_CASE( extract_attributes_simple ) {
|
||||
}
|
||||
|
||||
BOOST_AUTO_TEST_CASE( extract_parameters ) {
|
||||
std::string s1 = "";
|
||||
std::string s1;
|
||||
std::string s2 = "foo";
|
||||
std::string s3 = " foo \r\nAbc";
|
||||
std::string s4 = " \r\n foo ";
|
||||
@@ -410,7 +410,7 @@ BOOST_AUTO_TEST_CASE( case_insensitive_headers_overwrite ) {
|
||||
BOOST_AUTO_TEST_CASE( blank_consume ) {
|
||||
websocketpp::http::parser::request r;
|
||||
|
||||
std::string raw = "";
|
||||
std::string raw;
|
||||
|
||||
bool exception = false;
|
||||
|
||||
|
||||
@@ -165,7 +165,7 @@ BOOST_AUTO_TEST_CASE( deflate_init ) {
|
||||
<< websocketpp::utility::to_hex(test_out,test_out_size) << std::endl;
|
||||
|
||||
std::string input = "Hello";
|
||||
std::string output = "";
|
||||
std::string output;
|
||||
ec = de.compress(input,output);
|
||||
|
||||
BOOST_CHECK( ec == processor::extensions::error::uninitialized );
|
||||
@@ -181,7 +181,7 @@ BOOST_AUTO_TEST_CASE( deflate_init ) {
|
||||
<< websocketpp::utility::to_hex(input) << std::endl
|
||||
<< websocketpp::utility::to_hex(output) << std::endl;
|
||||
|
||||
output = "";
|
||||
output.clear();
|
||||
|
||||
ec = de.compress(input,output);
|
||||
std::cout << ec.message() << std::endl
|
||||
@@ -189,7 +189,7 @@ BOOST_AUTO_TEST_CASE( deflate_init ) {
|
||||
<< websocketpp::utility::to_hex(output) << std::endl;
|
||||
|
||||
input = output;
|
||||
output = "";
|
||||
output.clear();
|
||||
ec = de.decompress(input,output);
|
||||
std::cout << ec.message() << std::endl
|
||||
<< websocketpp::utility::to_hex(input) << std::endl
|
||||
|
||||
@@ -103,7 +103,7 @@ bool validate_func_subprotocol(server* s, std::string* out, std::string accept,
|
||||
|
||||
*out = o.str();
|
||||
|
||||
if (accept != "") {
|
||||
if (!accept.empty()) {
|
||||
con->select_subprotocol(accept);
|
||||
}
|
||||
|
||||
|
||||
@@ -88,7 +88,7 @@ BOOST_AUTO_TEST_CASE( value_extraction ) {
|
||||
|
||||
BOOST_AUTO_TEST_CASE( extract_empty ) {
|
||||
lib::error_code ec;
|
||||
std::string payload = "";
|
||||
std::string payload;
|
||||
|
||||
BOOST_CHECK( close::extract_code(payload,ec) == close::status::no_status );
|
||||
BOOST_CHECK( !ec );
|
||||
@@ -109,12 +109,12 @@ BOOST_AUTO_TEST_CASE( extract_reason ) {
|
||||
BOOST_CHECK( close::extract_reason(payload,ec) == "Foo" );
|
||||
BOOST_CHECK( !ec );
|
||||
|
||||
payload = "";
|
||||
BOOST_CHECK( close::extract_reason(payload,ec) == "" );
|
||||
payload.clear();
|
||||
BOOST_CHECK( close::extract_reason(payload,ec).empty() );
|
||||
BOOST_CHECK( !ec );
|
||||
|
||||
payload = "00";
|
||||
BOOST_CHECK( close::extract_reason(payload,ec) == "" );
|
||||
BOOST_CHECK( close::extract_reason(payload,ec).empty() );
|
||||
BOOST_CHECK( !ec );
|
||||
|
||||
payload = "000";
|
||||
|
||||
Reference in new issue
Block a user