From 349717ad4608a2b4b29224412e31f056a40bb956 Mon Sep 17 00:00:00 2001 From: Peter Thorson Date: Fri, 27 Feb 2015 07:45:39 -0500 Subject: [PATCH] set default extension offer string Currently the offer is for default settings and advertises the ability to accept any counteroffer. --- .../extensions/permessage_deflate/disabled.hpp | 11 +++++++++++ websocketpp/extensions/permessage_deflate/enabled.hpp | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/websocketpp/extensions/permessage_deflate/disabled.hpp b/websocketpp/extensions/permessage_deflate/disabled.hpp index 5d2dd54..49c0e1d 100644 --- a/websocketpp/extensions/permessage_deflate/disabled.hpp +++ b/websocketpp/extensions/permessage_deflate/disabled.hpp @@ -88,6 +88,17 @@ public: return false; } + /// Generate extension offer + /** + * Creates an offer string to include in the Sec-WebSocket-Extensions + * header of outgoing client requests. + * + * @return A WebSocket extension offer string for this extension + */ + std::string generate_offer() const { + return ""; + } + /// Compress bytes /** * @param [in] in String to compress diff --git a/websocketpp/extensions/permessage_deflate/enabled.hpp b/websocketpp/extensions/permessage_deflate/enabled.hpp index 8e92990..9afbb5c 100644 --- a/websocketpp/extensions/permessage_deflate/enabled.hpp +++ b/websocketpp/extensions/permessage_deflate/enabled.hpp @@ -439,7 +439,8 @@ public: * @return A WebSocket extension offer string for this extension */ std::string generate_offer() const { - return ""; + // TODO: this should be dynamically generated based on user settings + return "permessage-deflate; client_no_context_takeover; client_max_window_bits"; } /// Validate extension response