mirror of
https://github.com/langgenius/dify.git
synced 2026-10-04 13:47:55 +08:00
Charles YaoandClaude Opus 4.8
cd5fb6bbf0
Final consolidated fix wave from whole-branch review of the Real Build +
Edit Cognition slice:
- _ground now overwrites the model dict on ANY create_node whose config
carries a model dict (llm, question-classifier, parameter-extractor),
not just "llm", so a drifted/hallucinated provider/name on those other
node types no longer flows through ungrounded.
- to_intents now carries a generator edge's sourceHandle/targetHandle
into the connect intent's args (source_handle/target_handle) so
branching nodes (if-else, question-classifier) wire onto the correct
port instead of collapsing onto the default handle; edges without
handles still produce bare {from_node, to_node} args.
- Cleared the 17 ruff errors (PT018/E302/E306/E501) across the slice's
test files by splitting composite asserts, adding missing blank
lines, and wrapping long lines -- no assertions weakened, no noqa.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
74 lines
2.8 KiB
Python
74 lines
2.8 KiB
Python
from unittest.mock import patch
|
|
|
|
|
|
def test_list_tenant_resources_normalizes_all_three_kinds():
|
|
from services.dify_builder.agent import resources
|
|
|
|
class _Model:
|
|
def __init__(self, m): self.model = m
|
|
|
|
class _ProvResp:
|
|
def __init__(self, p, ms): self.provider, self.models = p, [_Model(m) for m in ms]
|
|
|
|
class _DS:
|
|
def __init__(self, i, n): self.id, self.name = i, n
|
|
|
|
tool_record = {
|
|
"provider_name": "google", "tool_name": "search",
|
|
"tool_label": "Google Search", "description": "",
|
|
}
|
|
with patch.object(resources, "_list_models", return_value=[_ProvResp("anthropic", ["claude-opus-4-8"])]), \
|
|
patch.object(resources, "_list_datasets", return_value=[_DS("kb-1", "Company KB")]), \
|
|
patch.object(resources, "_list_tools", return_value=[tool_record]):
|
|
out = resources.list_tenant_resources("t1")
|
|
|
|
assert out.models[0].id == "anthropic/claude-opus-4-8"
|
|
assert out.datasets[0].id == "kb-1"
|
|
assert out.datasets[0].label == "Company KB"
|
|
assert out.tools[0].id == "google/search"
|
|
assert out.tools[0].label == "Google Search"
|
|
|
|
|
|
def test_each_source_degrades_to_empty():
|
|
from services.dify_builder.agent import resources
|
|
with patch.object(resources, "_list_models", side_effect=RuntimeError("boom")), \
|
|
patch.object(resources, "_list_datasets", side_effect=RuntimeError("boom")), \
|
|
patch.object(resources, "_list_tools", side_effect=RuntimeError("boom")):
|
|
out = resources.list_tenant_resources("t1")
|
|
assert out == resources.TenantResources(models=[], datasets=[], tools=[])
|
|
|
|
|
|
def test_mixed_failure_partial_success():
|
|
from services.dify_builder.agent import resources
|
|
|
|
class _DS:
|
|
def __init__(self, i, n): self.id, self.name = i, n
|
|
|
|
tool_record = {
|
|
"provider_name": "google", "tool_name": "search",
|
|
"tool_label": "Google Search", "description": "",
|
|
}
|
|
with patch.object(resources, "_list_models", side_effect=RuntimeError("boom")), \
|
|
patch.object(resources, "_list_datasets", return_value=[_DS("kb-1", "Company KB")]), \
|
|
patch.object(resources, "_list_tools", return_value=[tool_record]):
|
|
out = resources.list_tenant_resources("t1")
|
|
|
|
assert out.models == []
|
|
assert len(out.datasets) == 1
|
|
assert out.datasets[0].id == "kb-1"
|
|
assert len(out.tools) == 1
|
|
assert out.tools[0].id == "google/search"
|
|
|
|
|
|
def test_malformed_tool_record_degrades():
|
|
from services.dify_builder.agent import resources
|
|
|
|
with patch.object(resources, "_list_models", return_value=[]), \
|
|
patch.object(resources, "_list_datasets", return_value=[]), \
|
|
patch.object(resources, "_list_tools", return_value=[{"provider_name": "g"}]): # missing tool_name
|
|
out = resources.list_tenant_resources("t1")
|
|
|
|
assert out.tools == []
|
|
assert out.models == []
|
|
assert out.datasets == []
|