mirror of
https://github.com/langgenius/dify.git
synced 2026-10-04 13:47:55 +08:00
A generated http-request authorization without "type" made graphon's HttpRequestNodeAuthorization.check_config read values.data["type"] and raise KeyError; pydantic does not wrap it and validate_node_config only catches ValueError, so it escaped preflight_errors -> apply_repair and the live Build session ended in state=failed. - preflight_errors catches any exception per node and reports it as "node '<id>' (<type>): <ExcName>: <message>" (ValueError messages are unchanged), then keeps checking the remaining nodes. - The shared http-request normalizer (called by both the generator postprocess and apply_repair) fills a missing authorization type: "api-key" when config carries a non-empty api_key, else "no-auth" with config None, and reports the node as changed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
101 lines
3.5 KiB
Python
101 lines
3.5 KiB
Python
"""``preflight_errors``: the dry ``Graph.init`` a draft is put through before
|
|
it is written or run. Exercised on the REAL ESQ1-303 dev draft (app 0f11bedc,
|
|
dumped from dev on 2026-09-21), which the engine refused to start."""
|
|
|
|
import copy
|
|
import json
|
|
from pathlib import Path
|
|
|
|
from services.dify_builder.preflight import preflight_errors
|
|
|
|
_FIXTURES = Path(__file__).parent / "fixtures"
|
|
|
|
|
|
def _esq1_303_draft() -> dict:
|
|
return json.loads((_FIXTURES / "esq1_303_draft_graph.json").read_text(encoding="utf-8"))
|
|
|
|
|
|
def test_the_esq1_303_dev_draft_would_not_start_and_the_error_names_the_node():
|
|
errors = preflight_errors(_esq1_303_draft())
|
|
|
|
assert len(errors) == 1
|
|
assert errors[0].startswith("node 'node2' (if-else): ")
|
|
assert "Input should be a valid string" in errors[0] # value 60 is a JSON number
|
|
|
|
|
|
def test_the_same_draft_passes_once_the_value_is_a_string():
|
|
graph = _esq1_303_draft()
|
|
node2 = next(n for n in graph["nodes"] if n["id"] == "node2")
|
|
node2["data"]["cases"][0]["conditions"][0]["value"] = "60"
|
|
|
|
assert preflight_errors(graph) == []
|
|
|
|
|
|
def test_every_broken_node_is_reported_not_only_the_first():
|
|
graph = _esq1_303_draft()
|
|
broken_twice = copy.deepcopy(next(n for n in graph["nodes"] if n["id"] == "node2"))
|
|
broken_twice["id"] = "node2b"
|
|
graph["nodes"].append(broken_twice)
|
|
|
|
errors = preflight_errors(graph)
|
|
|
|
assert [e.split(" ")[1] for e in errors] == ["'node2'", "'node2b'"]
|
|
|
|
|
|
def test_note_widgets_are_skipped_exactly_like_graph_init_skips_them():
|
|
graph = {
|
|
"nodes": [
|
|
{"id": "note", "type": "custom-note", "data": {"type": "", "text": "remember"}},
|
|
{"id": "s", "type": "custom", "data": {"type": "start", "title": "Start", "variables": []}},
|
|
],
|
|
"edges": [],
|
|
}
|
|
|
|
assert preflight_errors(graph) == []
|
|
|
|
|
|
def test_an_empty_or_shapeless_graph_has_nothing_to_report():
|
|
assert preflight_errors({}) == []
|
|
assert preflight_errors({"nodes": [None, "junk"], "edges": []}) == []
|
|
|
|
|
|
def _http_node(node_id: str, authorization: dict) -> dict:
|
|
return {
|
|
"id": node_id,
|
|
"type": "custom",
|
|
"data": {
|
|
"type": "http-request",
|
|
"title": "Call",
|
|
"method": "post",
|
|
"url": "https://x.test/a",
|
|
"authorization": authorization,
|
|
"headers": "",
|
|
"params": "",
|
|
"body": {"type": "none", "data": []},
|
|
},
|
|
}
|
|
|
|
|
|
def test_an_authorization_without_type_is_reported_not_raised():
|
|
"""The live E2E crash: graphon's ``HttpRequestNodeAuthorization.check_config``
|
|
reads ``values.data["type"]``, which is absent once the required ``type``
|
|
failed, so it raises KeyError -- which pydantic does not wrap and
|
|
``validate_node_config`` does not catch. A validation step must report
|
|
it, never crash the Builder session. Built WITHOUT the normalizer."""
|
|
graph = {"nodes": [_http_node("h", {"config": {"type": "bearer", "api_key": "x"}})], "edges": []}
|
|
|
|
errors = preflight_errors(graph)
|
|
|
|
assert errors == ["node 'h' (http-request): KeyError: 'type'"]
|
|
|
|
|
|
def test_a_crashing_node_does_not_hide_the_problems_of_the_nodes_after_it():
|
|
graph = _esq1_303_draft()
|
|
graph["nodes"].insert(0, _http_node("h", {"type": "bearer", "config": {"type": "bearer", "api_key": "x"}}))
|
|
|
|
errors = preflight_errors(graph)
|
|
|
|
assert [e.split(" ")[1] for e in errors] == ["'h'", "'node2'"]
|
|
assert errors[0].startswith("node 'h' (http-request): KeyError: ")
|
|
assert errors[1].startswith("node 'node2' (if-else): ") # ValueError messages unchanged
|