Charles YaoandClaude Opus 4.8 2b4df02305 fix(dify_builder): close SSE subscription even when the response is never iterated ...

progress_bus.subscribe() eagerly enters the pub/sub subscription (opening a
Redis connection + starting a listener thread) BEFORE the SSE generator
exists, so the subscribe completes before the Celery advance can publish.
But the only close() lived in the generator's finally -- which Python does
not run if the generator is never started. A streaming Response dropped
before its first frame (client aborted, or an after_request/teardown error)
therefore leaked the connection + thread until process restart.

stream_advance_frames now returns a small _ClosingFrameStream wrapper whose
close() closes the subscription directly (idempotent); the WSGI server calls
close() on the response iterable even on early disconnect, so cleanup fires
regardless of iteration. The inner generator keeps its own finally for the
iterated/disconnect paths, so this is strictly additive -- no happy-path
change. All seven call sites get it unchanged.

Adds a regression test (never-iterated stream -> close() -> subscription closed).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-09-03 08:48:23 +08:00

..

agent

test: migrate model and agent sessions to SQLite (#40087)

2026-08-31 05:57:40 +00:00

auth

refactor(api): decouple data source API key auth flow (#40452)

2026-08-18 04:30:17 +00:00

data_migration

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

dify_builder

fix(dify_builder): close SSE subscription even when the response is never iterated

2026-09-03 08:48:23 +08:00

enterprise

fix(rbac): grant agent access to all legacy roles (#41511)

2026-08-31 03:33:09 +00:00

openapi

test: eliminate remaining whole config mocks (#40855)

2026-08-18 12:01:49 +00:00

plugin

test: add tmp_path type (#40724)

2026-08-21 06:09:39 +00:00

rag_pipeline

test: migrate application DSL sessions and ORM models to SQLite (#40554)

2026-08-29 14:06:07 +00:00

retention

refactor(api): extract workflow run archive application service (#41253)

2026-08-27 02:41:43 +00:00

tools

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

workflow

test: migrate application DSL sessions and ORM models to SQLite (#40554)

2026-08-29 14:06:07 +00:00

__init__.py

…

controller_api.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

dataset_service_test_helpers.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00

document_service_validation.py

test: use sqlite sessions in rag pipeline coverage (#40093)

2026-08-11 06:19:08 +00:00

hit_service.py

…

test_account_activation_adapters.py

feat: new user add automatic add to app / dataset whitelist (#41363)

2026-08-27 08:51:05 +00:00

test_account_activation_service.py

feat: new user add automatic add to app / dataset whitelist (#41363)

2026-08-27 08:51:05 +00:00

test_account_avatar_file_gateway.py

refactor(api): move account access behind application services (#40437)

2026-08-21 05:56:30 +00:00

test_account_avatar_service.py

refactor(api): move account access behind application services (#40437)

2026-08-21 05:56:30 +00:00

test_account_billing_adapters.py

refactor(api): complete account education boundary (#41153)

2026-08-25 01:48:12 +00:00

test_account_change_email_adapters.py

refactor(api): extract change email state machine (#40439)

2026-08-21 08:13:23 +00:00

test_account_change_email_service.py

refactor(api): extract change email state machine (#40439)

2026-08-21 08:13:23 +00:00

test_account_deletion_adapters.py

refactor(api): extract change email state machine (#40439)

2026-08-21 08:13:23 +00:00

test_account_deletion_feedback_service.py

refactor(api): finish account controller application boundary (#40440)

2026-08-21 08:46:06 +00:00

test_account_deletion_service.py

refactor(api): move account lifecycle into application services (#40438)

2026-08-21 08:05:43 +00:00

test_account_education_service.py

refactor(api): complete account education boundary (#41153)

2026-08-25 01:48:12 +00:00

test_account_email_registration_adapters.py

refactor(api): extract email registration application service (#41108)

2026-08-31 03:22:01 +00:00

test_account_email_registration_service.py

refactor(api): extract email registration application service (#41108)

2026-08-31 03:22:01 +00:00

test_account_email.py

fix(auth): normalize Gmail registration emails (#41249)

2026-08-26 07:14:27 +00:00

test_account_initialization_service.py

refactor(api): move account lifecycle into application services (#40438)

2026-08-21 08:05:43 +00:00

test_account_integration_service.py

refactor(api): move account access behind application services (#40437)

2026-08-21 05:56:30 +00:00

test_account_password_hasher.py

refactor(api): move account access behind application services (#40437)

2026-08-21 05:56:30 +00:00

test_account_password_service.py

refactor(api): move account access behind application services (#40437)

2026-08-21 05:56:30 +00:00

test_account_profile_service.py

refactor(api): add account profile application service (#40436)

2026-08-20 05:03:08 +00:00

test_account_service.py

fix(api): keep workspace owner consistent on ownership transfer (#41267)

2026-08-31 02:51:19 +00:00

test_agent_app_feature_service.py

…

test_agent_app_sandbox_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_agent_config_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_agent_llm_inner_service.py

feat(api): track credit usage contexts (#41181)

2026-08-25 10:21:32 +00:00

test_agent_tool_inner_service.py

…

test_annotation_service.py

test: migrate annotation sessions and ORM models to SQLite (#40504)

2026-08-21 06:09:26 +00:00

test_api_token_service.py

test: migrate media and execution service sessions and ORM models to SQLite (#40552)

2026-08-20 05:11:46 +00:00

test_app_definition_query_service.py

refactor(api): reuse app definition queries for service API site (#40795)

2026-08-19 07:23:47 +00:00

test_app_dsl_service.py

test: migrate application DSL sessions and ORM models to SQLite (#40554)

2026-08-29 14:06:07 +00:00

test_app_generate_service_streaming_integration.py

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

test_app_generate_service.py

fix(workflow): block manual runs for trigger workflows (#41519)

2026-08-31 09:30:52 +00:00

test_app_model_config_service.py

test: migrate service boundary sessions and ORM models to SQLite (#40533)

2026-08-18 12:23:33 +00:00

test_app_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_app_site_service.py

refactor(api): extract console app site command boundary (#41216)

2026-08-26 06:31:06 +00:00

test_app_task_service.py

…

test_archive_workflow_run_logs.py

test: eliminate remaining whole config mocks (#40855)

2026-08-18 12:01:49 +00:00

test_async_workflow_service.py

test: migrate media and execution service sessions and ORM models to SQLite (#40552)

2026-08-20 05:11:46 +00:00

test_audio_service.py

feat(api): track credit usage contexts (#41181)

2026-08-25 10:21:32 +00:00

test_batch_indexing_base.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00

test_billing_portal_service.py

refactor(api): standardize console billing portal errors (#41055)

2026-08-24 01:55:48 +00:00

test_billing_service.py

refactor(api): standardize compliance downloads (#41057)

2026-08-26 06:32:13 +00:00

test_clear_free_plan_expired_workflow_run_logs.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_clear_free_plan_tenant_expired_logs.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_code_based_extension_service.py

…

test_compliance_download_service.py

refactor(api): standardize compliance downloads (#41057)

2026-08-26 06:32:13 +00:00

test_conversation_service.py

test: eliminate remaining whole config mocks (#40855)

2026-08-18 12:01:49 +00:00

test_credential_permission_service.py

test: migrate residual service and task ORM models to SQLite (#40576)

2026-08-18 12:26:01 +00:00

test_credit_pool_service.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_data_source_oauth_service.py

refactor(api): thin OAuth controllers and extract application services (#40692)

2026-08-26 07:33:37 +00:00

test_dataset_service_dataset.py

test: centralize controller and storage config overrides (#40867)

2026-08-28 14:47:17 +00:00

test_dataset_service_document.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_dataset_service_lock_not_owned.py

test: migrate audit findings sessions and ORM models to SQLite (#40551)

2026-08-31 05:55:38 +00:00

test_dataset_service_segment.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_datasource_provider_service.py

test: scope plugin and datasource config overrides (#40854)

2026-08-18 12:01:29 +00:00

test_document_indexing_task_proxy.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00

test_duplicate_document_indexing_task_proxy.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00

test_email_code_login_challenge.py

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

test_export_app_messages.py

…

test_external_dataset_service.py

test: migrate service boundary sessions and ORM models to SQLite (#40533)

2026-08-18 12:23:33 +00:00

test_feature_entities.py

fix(web): render workspace plan badge during SSR (#40581)

2026-08-12 07:45:39 +00:00

test_feature_query_service.py

fix(api): scope hosted credits by tenant plan (#41131)

2026-08-24 06:35:42 +00:00

test_feature_service_app_dsl_version.py

refactor(api): decouple console queries through application services (#40031)

2026-08-07 00:42:55 +00:00

test_feature_service_change_email.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_deployment_edition.py

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

test_feature_service_dify_builder.py

feat(dify-builder): add DIFY_BUILDER_SKILL_LEARNING_POLICY config + FeatureService surface (C-2)

2026-08-23 12:38:04 -07:00

test_feature_service_enable_app_deploy.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00

test_feature_service_explore_banner.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_gateway.py

fix(api): scope hosted credits by tenant plan (#41131)

2026-08-24 06:35:42 +00:00

test_feature_service_human_input_email_delivery.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_internal_policies.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_knowledge_file_size_limit.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_knowledge_fs.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_learn_app.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_license_expiry_notice.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_licensed_seats.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_plugin_installation_permission.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_skill.py

feat: hide add library skill in agent ui (#41250)

2026-08-25 10:26:06 +00:00

test_feature_service_sso_protocol.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00

test_feature_service_trial_models.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feature_service_vector_space.py

test: eliminate remaining whole config mocks (#40855)

2026-08-18 12:01:49 +00:00

test_feature_service_webapp_public_access.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_feedback_service.py

fix(api): end_date filter in feedback export excludes the entire end date (#40114)

2026-08-10 03:27:56 +00:00

test_file_request_service.py

…

test_file_service.py

test: centralize controller and storage config overrides (#40867)

2026-08-28 14:47:17 +00:00

test_hit_testing_service.py

…

test_human_input_delivery_test_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_human_input_file_upload_service.py

test: migrate human input sessions and ORM models to SQLite (#40597)

2026-08-27 12:15:07 +00:00

test_human_input_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_init_validation_service.py

refactor(api): extract init validation into layered application service (#40046)

2026-08-12 08:42:09 +00:00

test_knowledge_fs_proxy.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_knowledge_retrieval_inner_service.py

…

test_message_service.py

test: migrate media and execution service sessions and ORM models to SQLite (#40552)

2026-08-20 05:11:46 +00:00

test_messages_clean_service.py

test: eliminate remaining whole config mocks (#40855)

2026-08-18 12:01:49 +00:00

test_metadata_bug_complete.py

fix(api): bind dataset operations to owners (#40149)

2026-08-11 16:37:14 +00:00

test_metadata_nullable_bug.py

fix(api): bind dataset operations to owners (#40149)

2026-08-11 16:37:14 +00:00

test_metadata_service_session_boundary.py

test: migrate service boundary sessions and ORM models to SQLite (#40533)

2026-08-18 12:23:33 +00:00

test_model_load_balancing_service.py

feat: support azure keyvault (#39933)

2026-08-07 00:42:13 +00:00

test_model_provider_service_sanitization.py

…

test_model_provider_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_notification_gateway.py

refactor(api): decouple onboarding and notification services (#40759)

2026-08-31 04:37:07 +00:00

test_notification_service.py

refactor(api): decouple onboarding and notification services (#40759)

2026-08-31 04:37:07 +00:00

test_notion_data_source_gateway.py

refactor(api): thin OAuth controllers and extract application services (#40692)

2026-08-26 07:33:37 +00:00

test_oauth_device_flow.py

…

test_oauth_server_service.py

refactor(api): thin OAuth controllers and extract application services (#40692)

2026-08-26 07:33:37 +00:00

test_operation_service.py

…

test_rag_pipeline_task_proxy.py

test: migrate RAG processor residuals to SQLite ORM models (#40608)

2026-08-15 09:54:09 +00:00

test_recommended_app_catalog_gateway.py

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

test_recommended_app_query_service.py

refactor(api): replace legacy recommended app retrieval stack (#40395)

2026-08-20 13:13:43 +00:00

test_schedule_service.py

…

test_schema_definition_service.py

refactor(api): decouple setup and spec endpoints (#40104)

2026-08-08 11:52:15 +00:00

test_setup_adapters.py

refactor(api): standardize session factory wiring (#41085)

2026-08-24 01:57:17 +00:00

test_setup_service.py

refactor(api): decouple setup and spec endpoints (#40104)

2026-08-08 11:52:15 +00:00

test_skill_management_service.py

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

test_snippet_dsl_service.py

test: migrate application DSL sessions and ORM models to SQLite (#40554)

2026-08-29 14:06:07 +00:00

test_snippet_generate_service.py

test: migrate snippet service ORM models to SQLite (#40567)

2026-08-20 05:12:30 +00:00

test_snippet_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_step_by_step_tour_service.py

refactor(api): decouple onboarding and notification services (#40759)

2026-08-31 04:37:07 +00:00

test_summary_index_service.py

…

test_tag_application_service.py

feat: support agent skill (#39675)

2026-08-24 05:29:14 +00:00

test_telemetry_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_trigger_provider_service.py

…

test_trigger_subscription_builder_service.py

fix(api): scope temporary capabilities to owners (#39863)

2026-08-07 09:21:13 +00:00

test_turnstile_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_variable_truncator_additional.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_variable_truncator.py

…

test_vector_service.py

test: migrate media and execution service sessions and ORM models to SQLite (#40552)

2026-08-20 05:11:46 +00:00

test_vector_space_admission_service.py

test: centralize account and feature config overrides (#40864)

2026-08-28 14:47:16 +00:00

test_web_app_runtime_query_service.py

refactor(api): extract web app runtime bootstrap (#40949)

2026-08-20 05:05:31 +00:00

test_webapp_access_query_service.py

refactor(api): reuse web app access queries for permissions (#40984)

2026-08-20 02:27:49 +00:00

test_webhook_service_additional.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_webhook_service.py

test: migrate trigger and webhook sessions and ORM models to SQLite (#40594)

2026-08-24 04:01:02 +00:00

test_website_service.py

…

test_workflow_app_service_metadata.py

refactor(models): pass session into WorkflowAppLog accessors (#41440)

2026-08-28 14:32:27 +00:00

test_workflow_collaboration_service.py

test: enforce centralized config overrides (#40869)

2026-08-29 14:05:35 +00:00

test_workflow_comment_service.py

refactor: pass session to workflow comment account accessors (#41117)

2026-08-24 03:20:32 +00:00

test_workflow_generator_service.py

feat(api): track credit usage contexts (#41181)

2026-08-25 10:21:32 +00:00

test_workflow_node_execution_trace_service.py

test: migrate workflow node trace ORM models to real entities (#40657)

2026-08-13 05:19:52 +00:00

test_workflow_run_service_pause.py

…

test_workflow_run_service.py

test: migrate residual service and task ORM models to SQLite (#40576)

2026-08-18 12:26:01 +00:00

test_workflow_service.py

test: centralize core and service config overrides (#40868)

2026-08-29 14:05:34 +00:00

test_workflow_statistic_query_service.py

refactor(api): extract workflow statistic query service (#41271)

2026-08-27 02:41:02 +00:00

test_workspace_credit_pool.py

test: migrate service boundary sessions and ORM models to SQLite (#40533)

2026-08-18 12:23:33 +00:00

test_workspace_member_query_service.py

…

test_workspace_member_role_resolver.py

…

test_workspace_service.py

refactor(api): consolidate deployment edition handling (#40142)

2026-08-11 07:39:01 +00:00