fix(web): preserve link semantics in button-styled navigation (#41312)

This commit is contained in:
yyh authored and GitHub committed 2026-08-26 10:50:06 +00:00
1 parent 638dfd77a4
commit c8e29d9a7d
53 files changed
+587 -611

No files matched your search

@@ -10,13 +10,6 @@ import { renderWithConsoleQuery as render } from '@/test/console/query-data'
import { RETRIEVE_METHOD } from '@/types/app'
import EmbeddingProcess from '../index'
const mockPush = vi.fn()
vi.mock('@/next/navigation', () => ({
useRouter: () => ({
push: mockPush,
}),
}))
// Mock next/link
vi.mock('@/next/link', () => ({
default: function MockLink({
@@ -650,29 +643,15 @@ describe('EmbeddingProcess', () => {
})
describe('User Interactions', () => {
// Tests for button clicks and navigation
it('should navigate to document list when nav button is clicked', async () => {
it('should link to the document list and invalidate its cache on activation', () => {
const props = createDefaultProps({ datasetId: 'my-dataset-123' })
render(<EmbeddingProcess {...props} />)
const navButton = screen.getByText('datasetCreation.stepThree.navTo')
fireEvent.click(navButton)
const link = screen.getByRole('link', { name: 'datasetCreation.stepThree.navTo' })
expect(link).toHaveAttribute('href', '/datasets/my-dataset-123/documents')
fireEvent.click(link)
expect(mockInvalidDocumentList).toHaveBeenCalled()
expect(mockPush).toHaveBeenCalledWith('/datasets/my-dataset-123/documents')
})
it('should call invalidDocumentList before navigation', () => {
const props = createDefaultProps()
const callOrder: string[] = []
mockInvalidDocumentList.mockImplementation(() => callOrder.push('invalidate'))
mockPush.mockImplementation(() => callOrder.push('push'))
render(<EmbeddingProcess {...props} />)
const navButton = screen.getByText('datasetCreation.stepThree.navTo')
fireEvent.click(navButton)
expect(callOrder).toEqual(['invalidate', 'push'])
})
})
@@ -2,7 +2,7 @@ import type { IndexingType } from '@/app/components/datasets/create/step-two'
import type { IndexingStatusResponse } from '@/models/datasets'
import type { InitialDocumentDetail } from '@/models/pipeline'
import type { RETRIEVE_METHOD } from '@/types/app'
import { Button } from '@langgenius/dify-ui/button'
import { buttonVariants } from '@langgenius/dify-ui/button'
import { cn } from '@langgenius/dify-ui/cn'
import { Popover, PopoverContent, PopoverTrigger } from '@langgenius/dify-ui/popover'
import {
@@ -26,7 +26,6 @@ import { useProviderContext } from '@/context/provider-context'
import { useDatasetApiAccessUrl } from '@/hooks/use-api-access-url'
import { DatasourceType } from '@/models/pipeline'
import Link from '@/next/link'
import { useRouter } from '@/next/navigation'
import { useIndexingStatusBatch, useProcessRule } from '@/service/knowledge/use-dataset'
import { useInvalidDocumentList } from '@/service/knowledge/use-document'
import RuleDetail from './rule-detail'
@@ -47,7 +46,6 @@ const EmbeddingProcess = ({
retrievalMethod,
}: EmbeddingProcessProps) => {
const { t } = useTranslation()
const router = useRouter()
const { enableBilling, plan } = useProviderContext()
const [indexingStatusBatchDetail, setIndexingStatusDetail] = useState<IndexingStatusResponse[]>(
[],
@@ -86,10 +84,7 @@ const EmbeddingProcess = ({
const { data: ruleDetail } = useProcessRule(firstDocument!.id)
const invalidDocumentList = useInvalidDocumentList()
const navToDocumentList = () => {
invalidDocumentList()
router.push(`/datasets/${datasetId}/documents`)
}
const documentsHref = `/datasets/${datasetId}/documents`
const apiReferenceUrl = useDatasetApiAccessUrl()
const isEmbeddingWaiting = useMemo(() => {
@@ -255,16 +250,23 @@ const EmbeddingProcess = ({
/>
</div>
<div className="mt-6 flex items-center gap-x-2 py-2">
<Link href={apiReferenceUrl} target="_blank" rel="noopener noreferrer">
<Button className="w-fit">
<RiTerminalBoxLine className="size-4" />
<span>Access the API</span>
</Button>
<Link
href={apiReferenceUrl}
target="_blank"
rel="noopener noreferrer"
className={cn(buttonVariants(), 'w-fit')}
>
<RiTerminalBoxLine className="size-4" />
<span>Access the API</span>
</Link>
<Button className="w-fit" variant="primary" onClick={navToDocumentList}>
<Link
href={documentsHref}
className={cn(buttonVariants({ variant: 'primary' }), 'w-fit')}
onClick={invalidDocumentList}
>
<span>{t(($) => $['stepThree.navTo'], { ns: 'datasetCreation' })}</span>
<RiArrowRightLine className="size-4 stroke-current stroke-1" />
</Button>
</Link>
</div>
</>
)