diff --git a/.jenkins.d/00-deps.sh b/.jenkins.d/00-deps.sh index a287116..d3b16f9 100755 --- a/.jenkins.d/00-deps.sh +++ b/.jenkins.d/00-deps.sh @@ -42,4 +42,8 @@ elif has Ubuntu $NODE_LABELS; then pip3 install --user --upgrade --upgrade-strategy=eager sphinx sphinxcontrib-doxylink ;; esac + +elif has CentOS $NODE_LABELS; then + sudo dnf -y install gcc-c++ libasan pkgconf-pkg-config python3 \ + boost-devel openssl-devel sqlite-devel fi diff --git a/.jenkins.d/01-ndn-cxx.sh b/.jenkins.d/01-ndn-cxx.sh index 4e0e154..5da6d35 100755 --- a/.jenkins.d/01-ndn-cxx.sh +++ b/.jenkins.d/01-ndn-cxx.sh @@ -35,19 +35,14 @@ sudo rm -f /usr/local/lib{,64}/pkgconfig/libndn-cxx.pc pushd ndn-cxx >/dev/null -if has CentOS-8 $NODE_LABELS; then - # https://bugzilla.redhat.com/show_bug.cgi?id=1721553 - PCH="--without-pch" -fi - -./waf --color=yes configure --disable-static --enable-shared --without-osx-keychain $PCH +./waf --color=yes configure --disable-static --enable-shared --without-osx-keychain ./waf --color=yes build -j$WAF_JOBS sudo_preserve_env PATH -- ./waf --color=yes install popd >/dev/null popd >/dev/null -if has CentOS-8 $NODE_LABELS; then +if has CentOS $NODE_LABELS; then sudo tee /etc/ld.so.conf.d/ndn.conf >/dev/null <<< /usr/local/lib64 fi if has Linux $NODE_LABELS; then diff --git a/.jenkins.d/10-build.sh b/.jenkins.d/10-build.sh index 692ad2f..23c2987 100755 --- a/.jenkins.d/10-build.sh +++ b/.jenkins.d/10-build.sh @@ -36,6 +36,9 @@ fi # Install sudo_preserve_env PATH -- ./waf --color=yes install +if has CentOS $NODE_LABELS; then + sudo tee /etc/ld.so.conf.d/ndn.conf >/dev/null <<< /usr/local/lib64 +fi if has Linux $NODE_LABELS; then sudo ldconfig fi diff --git a/.jenkins.d/20-tests.sh b/.jenkins.d/20-tests.sh index 455c8f7..81c00b1 100755 --- a/.jenkins.d/20-tests.sh +++ b/.jenkins.d/20-tests.sh @@ -3,7 +3,6 @@ set -ex # Prepare environment rm -rf ~/.ndn -ndnsec key-gen "/tmp/jenkins/$NODE_NAME" | ndnsec cert-install - # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags ASAN_OPTIONS="color=always" diff --git a/.jenkins.d/40-headers-check.sh b/.jenkins.d/40-headers-check.sh index 369eba3..da13efa 100755 --- a/.jenkins.d/40-headers-check.sh +++ b/.jenkins.d/40-headers-check.sh @@ -6,20 +6,21 @@ # (similar to running all test cases), instead of failing at the first error. PROJ=PSync +PCFILE=PSync if [[ -n $DISABLE_HEADERS_CHECK ]]; then echo 'Skipping headers check.' exit 0 fi -if has CentOS-8 $NODE_LABELS; then +if has CentOS $NODE_LABELS; then export PKG_CONFIG_PATH=/usr/local/lib64/pkgconfig fi CXX=${CXX:-g++} STD=-std=c++14 -CXXFLAGS="-O2 -Wall -Wno-unneeded-internal-declaration -Wno-unused-const-variable $(pkg-config --cflags libndn-cxx $PROJ)" -INCLUDEDIR="$(pkg-config --variable=includedir $PROJ)"/$PROJ +CXXFLAGS="-O2 -Wall -Wno-unneeded-internal-declaration -Wno-unused-const-variable $(pkg-config --cflags libndn-cxx $PCFILE)" +INCLUDEDIR="$(pkg-config --variable=includedir $PCFILE)"/$PROJ echo "Using: $CXX $STD $CXXFLAGS" diff --git a/wscript b/wscript index 270ac19..4253101 100644 --- a/wscript +++ b/wscript @@ -39,7 +39,12 @@ def configure(conf): conf.env.WITH_EXAMPLES = conf.options.with_examples conf.env.WITH_TESTS = conf.options.with_tests - conf.find_program('dot', var='DOT', mandatory=False) + conf.find_program('dot', mandatory=False) + + # Prefer pkgconf if it's installed, because it gives more correct results + # on Fedora/CentOS/RHEL/etc. See https://bugzilla.redhat.com/show_bug.cgi?id=1953348 + # Store the result in env.PKGCONFIG, which is the variable used inside check_cfg() + conf.find_program(['pkgconf', 'pkg-config'], var='PKGCONFIG') pkg_config_path = os.environ.get('PKG_CONFIG_PATH', f'{conf.env.LIBDIR}/pkgconfig') conf.check_cfg(package='libndn-cxx', args=['libndn-cxx >= 0.8.0', '--cflags', '--libs'],